Deprecate inplace in Categorical.remove_unused_categories #37918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/arrays/categorical.py
Outdated
| @@ -1083,8 +1093,7 @@ def remove_unused_categories(self, inplace=False): | |||
| cat._dtype = new_dtype | |||
| cat._codes = coerce_indexer_dtype(inv, new_dtype.categories) | |||
|
|
|||
| if not inplace: | |||
| return cat | |||
There was a problem hiding this comment.
this doesnt get changed until we actually enforce the deprecation a few versions from now
| @@ -354,7 +354,7 @@ def test_validate_inplace_raises(self, value): | |||
| with pytest.raises(ValueError, match=msg): | |||
| cat.remove_categories(removals=["D", "E", "F"], inplace=value) | |||
|
|
|||
| with pytest.raises(ValueError, match=msg): | |||
| with tm.assert_produces_warning(FutureWarning): | |||
| cat.remove_unused_categories(inplace=value) | |||
There was a problem hiding this comment.
comment inside this block about why we're getting a FutureWarning.
im guessing this actually needs both the raises and the produces_warning, ie.
with pytest.raises(ValueError, match=msg):
with tm.assert_produces_warning(FutureWarning):
# GH#37918 inplace kwarg deprecated
cat.remove_unused_categories(inplace=value)
|
This is a very good start. For the checkbox at the top, since this doesn't handle all the relevant methods, it doesn't close the issue. Instead write below the checkboxes "xref #37643" |
|
@jbrockmendel Thanks for a quick review, I have updated this pull request according to your suggestions |
jreback
added
Categorical
This was referenced Nov 18, 2020
|
thanks @OlehKSS happy to have you do the rest .... |
5 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffRelated to #37643